Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical glitches on android #723

Open
iota-xSK opened this issue Oct 26, 2024 · 7 comments
Open

Graphical glitches on android #723

iota-xSK opened this issue Oct 26, 2024 · 7 comments

Comments

@iota-xSK
Copy link

I tried using Vello to develop an android app and while it runs, on some devices there are graphical glitches. I made a minimal example here. It is basically the simple example adapted to run on android using cargo mobile 2. Am I doing something wrong or is this a glitch with the library?

@DJMcNab
Copy link
Member

DJMcNab commented Oct 28, 2024

Does this reproduce with our with_winit example, which already runs on Android? Your example code is hard for us to use as it is all rights reserved, and so we don't have permission to run it.

Unfortunately, I don't have a device to hand with that GPU; it's hard to reproduce this without that. It seems most likely that the Vulkan implementation on that device is incorrect, but it's possible that a mistake on our end is causing this.

@iota-xSK
Copy link
Author

I am having issues with running it with cargo apk:

$ cargo apk run -p with_winit
Already configuring "src/main.rs"
Using package `with_winit` in `/home/iota/Downloads/vello/examples/with_winit/Cargo.toml`
Error: Invalid args.

As for the all rights reserved code, I just forgot to add a license, will do that now so that it's easier for you guys. Sorry for the mistake

@DJMcNab
Copy link
Member

DJMcNab commented Oct 28, 2024

Apologies, our readme is out of date. You need to run the command as:

cargo apk run -p with_winit --lib

DJMcNab added a commit to DJMcNab/vello that referenced this issue Oct 28, 2024
@iota-xSK
Copy link
Author

Thank you! Weirdly enough the glitches don't happen with those examples. I must have done something wrong when converting the simple example to android. Any other ideas? Maybe I can help debug this somehow since I own a device with the issue?

@DJMcNab
Copy link
Member

DJMcNab commented Oct 28, 2024

I don't have the bandwidth to dive into this right now, but if you do reach any conclusions I'd be interested to see them.

github-merge-queue bot pushed a commit that referenced this issue Oct 28, 2024
@iota-xSK
Copy link
Author

Understandable, I'll play around with it and report if I get findings. Thanks!

@iota-xSK
Copy link
Author

I found the issue - I left msaa16 antialiasing in my code. As soon as I set antialiasing to area only, it fixed everything and there were no more graphical glitches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants