-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce test scenes that demonstrate conflation artifacts #271
Conversation
ae2d537
to
d2f1050
Compare
Added two scenes that demonstrate conflation artifacts as described in linebender#49. The first scene demonstrates adjacent triangles and rects that belong to the same path and use opposite winding. The second scene demonstrates strokes with overlapping square caps (these strokes are currently expressed as rects painted with the NonZero fill rule).
d2f1050
to
dc2e669
Compare
@DJMcNab I'd be happy to change the colors for the test case if you prefer that. What you described is correct, in the The |
My only experience with colourblind-friendliness is from watching Cracking The Cryptic, where they prefer to use their blue and orange colours when colouring. I strongly suspect that red and green aren't a good set of colours to use, but I'm not certain what a good set would be. I don't have colourblindness, so without using external tools, I can't say if the scene in this PR is accessible. |
I changed the colors to the following. These foreground/background colors should maintain a high contrast across the types of colorblindness I'm aware of based on this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, these are useful for showing conflation artifacts and will be helpful for verifying that attempts to remove them actually work.
Added two scenes that demonstrate the conflation artifact problem as described in #49. The first scene demonstrates adjacent triangles and rects that belong to the same path and use opposite winding.
The second scene demonstrates strokes with overlapping square caps (these strokes are currently expressed as rects painted with the NonZero fill rule).