Use anyhow::Error in end-to-end tests
#1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the visual noise a bit.
Prepare to use the try operator `?` inside the test functions.
Reduce the code noise.
jvff
force-pushed
the
use-errors-in-end-to-end-tests
branch
from
fdf0cc7
to
a80e655
Compare
ma2bd
approved these changes
Apr 6, 2024
afck
reviewed
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Many of the
asynctests panic when an error occurs instead of propagating the error using the try operator (?). The reasoning for this was that panics preserve the backtrace. However, ifanyhow::Erroris used, it automatically captures and displays a backtrace as well.If the try operator (
?) is used instead of panics, the code becomes slightly less noisy.Proposal
Change the end-to-end tests to return
anyhow::Result<()>and replaceResult::unwrapcalls with the try operator.Test Plan
Two tests were temporarily changed to fail, to test if CI shows the backtrace even if the try operator is used.
Release Plan
Only affects tests, so nothing needed.
Links