Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: @lingui/macro article refinement #2055

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

andrii-bodnar
Copy link
Contributor

@andrii-bodnar andrii-bodnar commented Oct 17, 2024

Description

In this PR I have reorganized the @lingui/macro article. Some parts have been rearranged, rewritten or paraphrased. A few duplicates have been merged.

In the context of the recent changes (React and Core macros moved to their respective packages), I think the next step would be to split the content of this page between Introduction (Describing the concept in general), @lingui/core and @lingui/react.

🖼️ See the Deployment Preview.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Oct 18, 2024 6:51am

Copy link

github-actions bot commented Oct 17, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 3.09 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@andrii-bodnar andrii-bodnar merged commit 3a51350 into next Oct 18, 2024
9 of 10 checks passed
@andrii-bodnar andrii-bodnar deleted the docs/macro-article-refinement branch October 18, 2024 06:59
@andrii-bodnar andrii-bodnar added this to the v5 milestone Oct 23, 2024
@andrii-bodnar andrii-bodnar removed the v5 label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants