Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strip non essential only for production env #47

Merged

Conversation

taozhou-glean
Copy link
Contributor

@taozhou-glean taozhou-glean commented Apr 6, 2023

in the main codebase, it seems more common we check against production instead, this also helps dev with custom env like test ;)

@timofei-iatsenko timofei-iatsenko self-requested a review April 6, 2023 18:54
@taozhou-glean
Copy link
Contributor Author

thanks! also another qq, why the swc-plugin is a separate repo compared to the rest of members of the lingui family ? is it because its written in rust ? @andrii-bodnar ;)

@timofei-iatsenko
Copy link
Collaborator

timofei-iatsenko commented Apr 6, 2023

is it because its written in rust ?

@taozhou-glean yes

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taozhou-glean thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants