Feature/use lingui #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
timofei-iatsenko
force-pushed
the
feature/use-lingui
branch
from
a54115e
to
392441d
Compare
timofei-iatsenko
force-pushed
the
feature/use-lingui
branch
from
392441d
to
f39a534
Compare
|
@thekip the CI has failed after the merge - https://github.com/lingui/swc-plugin/actions/runs/10265376647 |
|
We just encounter this problem recently 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, it's not that easy as in the babel's version since SWC API is very limited. It's progressing slowly when I have a good mood. The code itself is real spaghetti, but it is what it is, here is my Rust knowledge is very limited
also many changes caused by rustfmt (analog of prettier for Rust). I think i have to apply it to the whole codebase after next branch would be merged (to avoid conflicts between main/next)
Port of: lingui/js-lingui#1859
Closes: #84