Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to output slow PID on fast DACs #312

Merged
merged 43 commits into from
Mar 21, 2023
Merged

Add ability to output slow PID on fast DACs #312

merged 43 commits into from
Mar 21, 2023

Conversation

bleykauf
Copy link
Collaborator

@bleykauf bleykauf commented Feb 28, 2023 •
edited
Loading

Based changes of original PR #284 on develop branch

Remaining issues:

  • when disabling slow_PID, the GUI element flips to "ANALOG_OUT0" (slow_PID output is off, though)
  • slow history is only shown for ANALOG_OUT0

@bleykauf bleykauf linked an issue Feb 28, 2023 that may be closed by this pull request
Two sets of PID for feedback on both OUT 1 and OUT 2. #282
Open
@bleykauf bleykauf mentioned this pull request Feb 28, 2023
Merged
@bleykauf
Copy link
Collaborator Author

Possibly related issues:
#288
#128
#180

@bleykauf bleykauf mentioned this pull request Mar 19, 2023
Closed
@bleykauf bleykauf mentioned this pull request Mar 21, 2023
Closed
@bleykauf bleykauf linked an issue Mar 21, 2023 that may be closed by this pull request
Second integrator on main output? #160
Closed
@bleykauf bleykauf marked this pull request as ready for review March 21, 2023 13:19
@bleykauf bleykauf merged commit 2794e04 into develop Mar 21, 2023
@bleykauf bleykauf deleted the feature/slow-integrator-fast-dacs branch March 21, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two sets of PID for feedback on both OUT 1 and OUT 2. Second integrator on main output?
2 participants
@bleykauf @cmf84