Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bit manipulation and remove myhdl dependency #12

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

fsagbuya
Copy link

@fsagbuya fsagbuya commented Mar 6, 2024

Hi, we are planning to use linien on our lab. Would like to propose some helpful updates for the pyp3 package.

This PR focuses on:

  • replacing the few instances of intbv from myhdl with native Python bitwise operations;
  • and removing the myhdl dependency from the project setup.

Given that intbv is utilized sparingly within the code, continuing to include myhdl as a dependency seems unnecessary and could potentially bloat the package.

Kindly requesting a review of these changes to validate the improvements and ensure no unintended side effects have been introduced. Your insights and approval would be greatly appreciated.

@bleykauf bleykauf changed the base branch from master to develop August 14, 2024 09:31
@bleykauf bleykauf merged commit 323d3a8 into linien-org:develop Aug 14, 2024
1 check was pending
@bleykauf
Copy link

Thanks for your PR, removing the myhdl dependency is a welcome change. I merged and released as part of version v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants