fix convergence test, phi3 import and update benchmark #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yundai424
changed the title
yundai424
changed the title
yundai424
changed the title
ByronHsu
previously approved these changes
Aug 29, 2024
ByronHsu
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Line 33 in c3c56e7
btw, we actually bump transformers to >= 4.41.0
ByronHsu
reviewed
Aug 29, 2024
| @@ -268,6 +267,8 @@ def apply_liger_kernel_to_phi3( | |||
| if cross_entropy: | |||
| modeling_phi3.CrossEntropyLoss = LigerCrossEntropyLoss | |||
| if fused_linear_cross_entropy: | |||
| from liger_kernel.transformers.model.phi3 import lce_forward as phi3_lce_forward | |||
There was a problem hiding this comment.
maybe we can move this back. we don't want to support too old transformers
There was a problem hiding this comment.
oh! apparently my mind swapped the 0 and 1 in the version, lemme revert these phi3 related stuff
yundai424
force-pushed
the
yudai/release
branch
from
3648716
to
573094e
Compare
ByronHsu
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
transformersversion doesn't carry phi3 source code (testing on 4.40.1), since we claim support for >= 4.40.1, change the import a bit so things still work on older HF verTesting Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence