Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MODEL_TO_LIGER_KERNEL_PATCHING_FUNC to minimize dependencies from external code #40

Closed
wants to merge 1 commit into from

Conversation

JasonZhu1313
Copy link
Collaborator

@JasonZhu1313 JasonZhu1313 commented Aug 17, 2024

Summary

Add MODEL_TO_LIGER_KERNEL_PATCHING_FUNC to minimize dependencies from external code

huggingface/transformers#32860 this is the PR for integrate liger kernel to HF, to minimize the dependencies, we shall only expose the dict

Testing Done

Tested in huggingface/transformers#32860 this is the PR for integrate liger kernel to HF, to minimize the dependencies

  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

Copy link
Collaborator

@ByronHsu ByronHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. let's wait for hf team

@ByronHsu
Copy link
Collaborator

duplicated w #42

@ByronHsu ByronHsu closed this Aug 19, 2024
@ByronHsu ByronHsu deleted the jaszhu/hf_integration branch August 23, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants