HEAD requests content-length is not based on the body as per the http… #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapaCharlie
reviewed
Apr 20, 2023
Comment on lines
93
to
96
| boolean addContentLengthHeader = true; | ||
| if ("HEAD".equalsIgnoreCase(request.getMethod())) { | ||
| addContentLengthHeader = false; | ||
| } |
There was a problem hiding this comment.
Isn't there a way to get this as an enum? Feels like a string equality check is a little weak... Otherwise, this feels better anyway:
boolean addContentLengthHeader = !"HEAD".equalsIgnoreCase(request.getMethod());There was a problem hiding this comment.
Agree enum is more cleaner way to do the check, but its not available in the repo without introducing additional dependencies.
Simplified the conditional statement as per the comment
bohhyang
approved these changes
Apr 20, 2023
… spec. Fixing it to not override the content-length if the request is HEADER type
… spec. Fixing it to not override the content-length if the request is HEADER type
nizarm
force-pushed
the
HEADER_CONTENT_LENGTH_FIX
branch
from
734075a
to
a647e7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEAD requests content-length is not based on the body as per the http spec. Fixing it to not override the content-length if the request is HEADER type