[test][controller] Fix multi-region tests to use VeniceTwoLayerMultiRegionMultiClusterWrapper #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiSernLim
previously approved these changes
Jul 16, 2024
...onTest/java/com/linkedin/venice/integration/utils/VeniceMultiRegionClusterCreateOptions.java
Outdated
Show resolved
Hide resolved
...egrationTest/java/com/linkedin/venice/integration/utils/VeniceMultiClusterCreateOptions.java
Outdated
Show resolved
Hide resolved
.../java/com/linkedin/venice/controller/kafka/consumer/AdminConsumptionTaskIntegrationTest.java
Outdated
Show resolved
Hide resolved
...t-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestWritePathComputation.java
Show resolved
Hide resolved
...st-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestStaleDataVisibility.java
Show resolved
Hide resolved
...st-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestStaleDataVisibility.java
Show resolved
Hide resolved
...st/java/com/linkedin/venice/controller/TestClusterLevelConfigForActiveActiveReplication.java
Show resolved
Hide resolved
KaiSernLim
approved these changes
Jul 17, 2024
|
Thanks a lot for the review @KaiSernLim |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multi-region tests to use
VeniceTwoLayerMultiRegionMultiClusterWrapperThere are several tests that create multi-region clusters through manual, non-standard setups. An example of this is that many tests create a multi-region cluster that shares the same Kafka cluster between them. While this might be valuable for some tests, it is a maintenance overhead for most of them. Our test suite already has
VeniceTwoLayerMultiRegionMultiClusterWrapperthat can be used directly for all current use-cases.This commit replaces all tests that setup a multi-region test cluster through non-standard means to use
VeniceTwoLayerMultiRegionMultiClusterWrapperinstead.This commit also fixes an issue where if the config to enable active active by default for batch-only stores is enabled, new store creation for system stores makes them also active-active. This was masked previously by different configs set on child and parent controllers. So, running this config in parent controller would have been problematic.
This change exposed another bug that storage persona only runs validations when running in a multi-region setups while there is nothing conceptually blocking it from running in a single-region setup. This will be addressed in a follow up PR.
How was this PR tested?
GH CI
Does this PR introduce any user-facing changes?