Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Merge VeniceControllerConfig and VeniceControllerClusterConfig #1070

Merged
merged 4 commits into from
Jul 22, 2024
Merged

[controller] Merge VeniceControllerConfig and VeniceControllerClusterConfig #1070

merged 4 commits into from
Jul 22, 2024

Conversation

nisargthakkar
Copy link
Contributor

@nisargthakkar nisargthakkar commented Jul 17, 2024 •
edited
Loading

Merge VeniceControllerConfig and VeniceControllerClusterConfig

Today, in controllers, we have two classes of configs which serve the same purpose, and it is unnecessary to maintain both. This commit merges VeniceControllerConfig and VeniceControllerClusterConfig.

How was this PR tested?

GH CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@nisargthakkar nisargthakkar enabled auto-merge (squash) July 18, 2024 18:31
sushantmane
sushantmane reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left few comments.

@nisargthakkar nisargthakkar enabled auto-merge (squash) July 22, 2024 16:47
sushantmane
sushantmane approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @nisargthakkar!

@nisargthakkar nisargthakkar merged commit 620ee8d into linkedin:main Jul 22, 2024
32 checks passed
@nisargthakkar nisargthakkar deleted the mergeVeniceControllerConfig branch July 22, 2024 17:17
@nisargthakkar nisargthakkar mentioned this pull request Jul 24, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantmane sushantmane sushantmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisargthakkar @sushantmane