[Server][FC] throws exception during store migration to enforce d2 refresh #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamxchen
commented
Aug 21, 2024
...enice-client/src/test/java/com/linkedin/venice/fastclient/meta/RequestBasedMetadataTest.java
Outdated
Show resolved
Hide resolved
xunyin8
requested changes
Aug 22, 2024
...s/venice-server/src/main/java/com/linkedin/venice/listener/ServerReadMetadataRepository.java
Show resolved
Hide resolved
xunyin8
reviewed
Aug 23, 2024
...s/venice-server/src/main/java/com/linkedin/venice/listener/ServerReadMetadataRepository.java
Outdated
Show resolved
Hide resolved
|
For a commit which changes the server, please include |
adamxchen
changed the title
# Conflicts: # internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestStoreMigration.java
xunyin8
reviewed
Sep 5, 2024
...s/venice-server/src/main/java/com/linkedin/venice/listener/ServerReadMetadataRepository.java
Outdated
Show resolved
Hide resolved
...ce-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestStoreMigration.java
Outdated
Show resolved
Hide resolved
xunyin8
approved these changes
Sep 7, 2024
|
Enabled the automerge but forgot to squash my commit msgs 😢 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As titled, we need to throw exceptions explicitly so FC can detect the store migration and refresh d2 service as needed. How it works is basically we compare the server cluster with the store cluster set on ZK. If they are different, it means the store migration has completed in the given region, so we can throw exception to refresh the service discovery.
How was this PR tested?
new unit tests and the integ test.
Does this PR introduce any user-facing changes?