[router][venice-thin-client] Add safeguard against invalid schema ID #1178
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixGV
reviewed
Sep 17, 2024
services/venice-router/src/main/java/com/linkedin/venice/router/MetaDataHandler.java
Show resolved
Hide resolved
services/venice-router/src/main/java/com/linkedin/venice/router/MetaDataHandler.java
Outdated
Show resolved
Hide resolved
services/venice-router/src/main/java/com/linkedin/venice/router/MetaDataHandler.java
Outdated
Show resolved
Hide resolved
FelixGV
approved these changes
Sep 17, 2024
m-nagarajan
pushed a commit
to m-nagarajan/venice
that referenced
this pull request
Sep 17, 2024
…inkedin#1178) If schema repo returns invalid schema id, that fails client requests. This PR adds safeguard against such invalid schemas in meta data handler and client side schema reader. --------- Co-authored-by: Sourav Maji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add safeguard against invalid schema ID in value schema lookup
If schema repo returns invalid schema id, that fails client requests. This PR adds safeguard against such invalid schemas in meta data handler and client side schema reader.
How was this PR tested?
CI
Does this PR introduce any user-facing changes?