[controller] Make setting instance group tags for controller cluster resources configurable #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resources configurable
nisargthakkar
requested changes
Sep 23, 2024
...troller/src/main/java/com/linkedin/venice/controller/VeniceControllerMultiClusterConfig.java
Outdated
Show resolved
Hide resolved
...-test-common/src/integrationTest/java/com/linkedin/venice/controller/TestHAASController.java
Outdated
Show resolved
Hide resolved
nisargthakkar
previously approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
Make setting instance group tags for controller cluster resources configurable. This is needed to provide cluster resource level isolation.
How was this PR tested?
Added new tests
Does this PR introduce any user-facing changes?