Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dvc] Add config to return Da Vinci specific ExecutionStatus for Errors #947

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

m-nagarajan
Copy link
Contributor

@m-nagarajan m-nagarajan commented Apr 17, 2024

Summary

  • Added a config use.da.vinci.specific.execution.status.for.error to enable/disable returning newly added Da Vinci specific ExecutionStatus for Errors in Controllers for DVC_INGESTION_ERROR_TOO_MANY_DEAD_INSTANCES and in Da Vinci clients for other DVC specific statuses.
  • Its disabled by default and can be enabled back again after the new code is in all components

How was this PR tested?

GH CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.
    New config use.da.vinci.specific.execution.status.for.error to enable/disable the new statuses.

Copy link
Contributor

@gaojieliu gaojieliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m-nagarajan m-nagarajan merged commit 560b804 into linkedin:main Apr 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants