Skip to content

Commit

Permalink
viz: Fix jaeger check test (#11425)
Browse files Browse the repository at this point in the history
64b66f9 changed the behavior of healthcheck.CheckProxyVersionsUpToDate
so that it errors when there are no channels provided. The viz tracing
test uses this utility to generate the expected error message, and it
did so without providing any channels.

This regression is fixed by instantiating the Channels struct with data.
  • Loading branch information
olix0r authored Sep 26, 2023
1 parent 64b66f9 commit b010b58
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/integration/viz/tracing/tracing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,11 @@ func TestTracing(t *testing.T) {
}

tpl := template.Must(template.ParseFiles("testdata" + "/" + golden))
versionErr := healthcheck.CheckProxyVersionsUpToDate(pods, version.Channels{})
chs, err := version.NewChannels("test-99.88.77")
if err != nil {
panic(err.Error())
}
versionErr := healthcheck.CheckProxyVersionsUpToDate(pods, chs)
versionErrMsg := ""
if versionErr != nil {
versionErrMsg = versionErr.Error()
Expand Down

0 comments on commit b010b58

Please sign in to comment.