Skip to content

Commit

Permalink
fix(ci): Disable arm64 install in release workflow (#12599)
Browse files Browse the repository at this point in the history
Our release workflow exercises an install on a manually managed ARM host. This
is fragile, and has fallen into disrepair. Practically speaking, we have never
found an issue in the ARM test -- if it builds, it works.

This commit removes the arm install from the release workflow.
  • Loading branch information
olix0r authored May 15, 2024
1 parent 5ec1f04 commit f241de1
Showing 1 changed file with 0 additions and 43 deletions.
43 changes: 0 additions & 43 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,49 +146,6 @@ jobs:
[[ "$TAG" == "$($CMD version --short --client)" ]]
bin/tests --images preload --name ${{ matrix.integration_test }} "$CMD"
arm64_integration_tests:
needs: [tag, docker_build]
runs-on: [self-hosted, Linux, ARM64]
timeout-minutes: 30
steps:
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version: "1.22"
- uses: docker/setup-buildx-action@d70bba72b1f3fd22344832f00baa16ece964efeb
- name: Pull linkerd binary
run: |
TAG='${{ needs.tag.outputs.tag }}'
bin/docker-pull-binaries "$TAG"
CMD="$PWD/target/release/linkerd2-cli-$TAG-linux-arm64"
echo "CMD=$CMD" >> "$GITHUB_ENV"
"$CMD" version --client
- uses: extractions/setup-just@dd310ad5a97d8e7b41793f8ef055398d51ad4de6
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: azure/setup-kubectl@3e0aec4d80787158d308d7b364cb1b702e7feb7f
- name: Setup k3d
shell: bash
run: |
mkdir -p "$PWD/target/bin"
PATH=$PATH:"$PWD/target/bin"
echo "PATH=$PATH" >> "$GITHUB_ENV"
bin/scurl "https://raw.githubusercontent.com/k3d-io/k3d/${{ env.K3D_VERSION }}/install.sh" \
| USE_SUDO=false K3D_INSTALL_DIR=$PWD/target/bin bash
- name: Cluster setup
run: |
CLUSTER_NAME=$(printf "${{ github.ref_name }}" | tr -c '[:alnum:]' -)
echo "CLUSTER_NAME=$CLUSTER_NAME" >> "$GITHUB_ENV"
just k3d-name="$CLUSTER_NAME" k3d-create
just k3d-name="$CLUSTER_NAME" k3d-use
- env:
RUN_ARM_TEST: 1
LINKERD_DOCKER_REGISTRY: ${{ env.DOCKER_REGISTRY }}
run: go test ./test/integration/deep/... --integration-tests --linkerd "$CMD"
- name: Delete cluster
if: always()
run: just k3d-name="$CLUSTER_NAME" k3d-delete

choco_pack:
# only runs for stable tags. The conditionals are at each step level instead of the job level
# otherwise the jobs below that depend on this one won't run
Expand Down

0 comments on commit f241de1

Please sign in to comment.