Make GrpcRoute watches optional #12917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Jul 31, 2024
Comment on lines
+146
to
+149
| err = renderCRDs(&crdManifest, valuespkg.Options{ | ||
| // GatewayAPI CRDs are optional so don't check for them. | ||
| Values: []string{"enableHttpRoutes=false"}, | ||
| }, "yaml") |
There was a problem hiding this comment.
This seems like a separate change Unrelated to the policy controller. Can we split it out?
There was a problem hiding this comment.
We could, but I consider both of these to be part of the same feature -- that Linkerd should work when the GrpcRoute CRD is absent.
olix0r
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the GrpcRoute CRD is not included in the Gateway API version 0.7.0 standard, we cannot rely on it being present in all clusters. Therefore, we make the GrpcRoute watch in the policy controller optional, conditioned on if the API resource exists. In fact, we do this for all HttpRoute as well.
This means that if either of these CRDs are not present on the cluster at the time that the policy controller is started, we will not initiate watches on that type and it will not be possible to use those resources for policy until the CRD is installed and the policy controller is restarted. We log at startup if any watches are skipped in this way.
Furthermore, we relax the
linkerd checkvalidation of CRDs to not require that gateway API CRDs are present.