Dual-stack support for ExternalWorkloads #12965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `workloadIPs.maxItems` field in the ExternalWorkload CRD from `1` to `2`, to accommodate for an IPv4 and IPv6 pair. This is a BC change, so there's no need to bump the CRD version. The control plane already supports this, so this change is mainly about expansions to the unit tests to also account for the double stack case.
zaharidichev
approved these changes
Aug 21, 2024
| svc := makeIPv4Service(map[string]string{"app": "test"}, []corev1.ServicePort{httpUnnamedPort}, "") | ||
| ew := makeExternalWorkload("1", "wlkd-1", map[string]string{"app": ""}, map[int32]string{8080: ""}, []string{"192.0.2.0"}) | ||
| ew.ObjectMeta.UID = types.UID(fmt.Sprintf("%s-%s", ew.Namespace, ew.Name)) | ||
| for _, tc := range []struct { |
There was a problem hiding this comment.
It seems there is no way to enforce that if we have two addresses, they should be of different type. Do you think its worth adding that and testing for it?
There was a problem hiding this comment.
We don't have a validating webhook for this resource, and I don't see a way of doing this with plain OpenAPI validation. Perhaps doable with CEL once we move to a MSKV 1.25?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
workloadIPs.maxItemsfield in the ExternalWorkload CRD from1to2, to accommodate for an IPv4 and IPv6 pair. This is a BC change, so there's no need to bump the CRD version.The control plane already supports this, so this change is mainly about expansions to the unit tests to also account for the double stack case.