add ability to read prometheus basic auth creds from secret #13035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Sep 6, 2024
Signed-off-by: Alex Leong <[email protected]>
olix0r
approved these changes
Sep 9, 2024
alpeb
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Wouldn't it be better to mount the secret? That way we don't need the extra RBAC nor the extra flags.
Also it might make sense to extract the client creation snippet into a reusable function that the new stat-inbound and stat-outbound commands can use, given they connect to Prometheus directly.
Comment on lines
91
to
93
| {{- if .Values.prometheusCredsSecret }} | ||
| - -prometheus-creds-secret={{.Values.prometheusCredsSecret}} | ||
| {{- end}} |
There was a problem hiding this comment.
TIOLI: use {{- with .Values.prometheusCredsSecret}} to avoid repeating .Values.prometheusCredsSecret and just using {{ . }}
Signed-off-by: Alex Leong <[email protected]>
alpeb
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Prometheus instance is configured with basic auth, the linkerd-viz metric-api is unable to access it. It is possible to provide basic auth credentials in the
prometheusUrlHelm value, but this leaks the credentials into the deployment manifest.We add a Helm value called
prometheusCredsSecretto the Linkerd-viz helm chart. When set, this causes the metrics-api to readuserandpasswordfields from a secret with the given name in the Linkerd-viz namespace and to use these values for basic auth when making requests to Prometheus.These credentials are loaded at startup and any changes to the credentials require a restart of the metrics-api to take effect.