Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout and failureThreshold to multicluster probe #13061

Merged
merged 2 commits into from
Sep 25, 2024

Commits on Sep 11, 2024

  1. Add timeout and failureThreshold to multicluster probe

    - This adds the `probeSpec.failureThreshold` and `probeSpec.timeout` fields to the Link CRD spec.
    - Likewise, the `gateway.probe.failureThreshold` and `gateway.probe.timeout` fields are added to the linkerd-multicluster chart, that are used to populate the new `mirror.linkerd.io/probe-failure-threshold` and `mirror.linkerd.io/probe-timeout` annotations in the gateway service (consumed by `linkerd mc link` to populate probe spec).
    - In the probe worker, we replace the hard-coded 50s timeout with the new timeout config (which now defaults to 30s). And the probe loop got refactored in order to not mark the gateway as unhealty until the consecutive failures threshold is reached.
    alpeb committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c96ed49 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Make probeTicker.C synchronous

    alpeb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f88566b View commit details
    Browse the repository at this point in the history