Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add nginxinc ingress controller example to tasks #1683

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

yohanb
Copy link
Contributor

@yohanb yohanb commented Sep 18, 2023

Adds the Nginx Inc ingress controller to the tasks documentation.

@yohanb yohanb force-pushed the docs/add_nginx_inc_ingress_to_tasks branch 3 times, most recently from aa9d9d0 to 136aa00 Compare September 18, 2023 18:25
@kflynn
Copy link
Member

kflynn commented Sep 21, 2023

@yohanb This looks really great! Can you fix the lint failures and then we'll get this landed? 🙂

@yohanb yohanb force-pushed the docs/add_nginx_inc_ingress_to_tasks branch 2 times, most recently from 645181e to 0888587 Compare September 21, 2023 16:52
@yohanb yohanb force-pushed the docs/add_nginx_inc_ingress_to_tasks branch from 0888587 to a1fb65d Compare September 21, 2023 16:54
@yohanb
Copy link
Contributor Author

yohanb commented Sep 21, 2023

@yohanb This looks really great! Can you fix the lint failures and then we'll get this landed? 🙂

@kflynn should be good now!

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much!! 🙂

@kflynn
Copy link
Member

kflynn commented Oct 3, 2023

So sorry that I lost track of this one for a bit! Looks great, thanks very much!! 🙂

@kflynn kflynn merged commit 0bcf829 into linkerd:main Oct 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants