-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graceful shutdown docs #1816
Conversation
Signed-off-by: Alex Leong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, though I think @alpeb's review before merging would be good too. 🙂
To address this, you can issue a POST to the `/shutdown` endpoint on the proxy | ||
### Native Sidecar | ||
|
||
If you use the `--set nativeSidecar=true` flag when installing Linkerd, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be --set proxy.nativeSidecar=true
that will allow Linkerd to handle these situations automatically. | ||
For security reasons, the proxy's `/shutdown` endpoint is disabled by default. | ||
In order to be able to manually shutdown the proxy, you must enable this | ||
endpoint by installing Linkerd with the `--set enableShutdownEndpoint=true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, should be proxy.enableShutdownEndpoint=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo my two comments above.
Signed-off-by: Alex Leong <[email protected]>
* Update graceful shutdown docs Signed-off-by: Alex Leong <[email protected]>
No description provided.