Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graceful shutdown docs #1816

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Update graceful shutdown docs #1816

merged 2 commits into from
Aug 9, 2024

Conversation

adleong
Copy link
Member

@adleong adleong commented Aug 6, 2024

No description provided.

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though I think @alpeb's review before merging would be good too. 🙂

To address this, you can issue a POST to the `/shutdown` endpoint on the proxy
### Native Sidecar

If you use the `--set nativeSidecar=true` flag when installing Linkerd, the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be --set proxy.nativeSidecar=true

that will allow Linkerd to handle these situations automatically.
For security reasons, the proxy's `/shutdown` endpoint is disabled by default.
In order to be able to manually shutdown the proxy, you must enable this
endpoint by installing Linkerd with the `--set enableShutdownEndpoint=true`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, should be proxy.enableShutdownEndpoint=true

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo my two comments above.

Signed-off-by: Alex Leong <[email protected]>
@adleong adleong merged commit 7f3c8ae into alpeb/2.16 Aug 9, 2024
3 checks passed
@adleong adleong deleted the alex/graceful-shutdown branch August 9, 2024 17:48
alpeb pushed a commit that referenced this pull request Aug 13, 2024
* Update graceful shutdown docs

Signed-off-by: Alex Leong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants