Update traefik ingress docs #1855
Conversation
There was a problem hiding this comment.
Thanks @chicocvenancio! There are a few tweaks that I'd like to see, but this looks way better than what we had before and I appreciate it! 🙂
| ```yaml | ||
| ingress.kubernetes.io/custom-request-headers: l5d-dst-override:web-svc.emojivoto.svc.cluster.local:80 | ||
| ``` | ||
| Previous versions of Ttraefik needed to use [ingress mode](#ingress-mode), |
There was a problem hiding this comment.
| Previous versions of Ttraefik needed to use [ingress mode](#ingress-mode), | |
| Versions of Traefik prior to 2.10 must use [ingress mode](#ingress-mode), |
|
|
||
| ```yaml | ||
| apiVersion: traefik.containo.us/v1alpha1 | ||
| apiVersion: traefik.io/v1alpha1 |
There was a problem hiding this comment.
What version of Traefik is required for this API group change?
There was a problem hiding this comment.
Version 2.10 as well. traefik.containo.us is dropped in v3.
There was a problem hiding this comment.
I left new api group for versions 2.10 and up example but kept old group for the legacy example.
There was a problem hiding this comment.
Thanks @chicocvenancio! This looks great save for one small typo.
|
Also, it would be lovely if you could add the DCO signature to your commits (or just confirm here that you're OK with the DCO). |
Fixes linkerd#1633 Signed-off-by: Chico Venancio <[email protected]>
Signed-off-by: Chico Venancio <[email protected]>
Signed-off-by: Chico Venancio <[email protected]>
chicocvenancio
force-pushed
the
traefik-docs
branch
from
65d6ca7
to
2555819
Compare
|
Rebased to sign off all commits and fixed the typo. |
|
Looks like this needs to have |
|
Thanks for sticking with this one, @chicocvenancio! 🙂 |
Fixes #1633