Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor card #1872

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Refactor card #1872

merged 2 commits into from
Nov 5, 2024

Conversation

travisbeckham
Copy link
Collaborator

@travisbeckham travisbeckham commented Nov 5, 2024

The card component has been refactored so that it no longer has breakpoint classes to be more consistent with other components, and to provide more flexibility. With this PR, if you want to change the options of the card at a breakpoint, apply a card mixin. For example:

Current:

<div class="card card-md-reverse">...

With this PR:

@media (min-width: breakpoint-min-width("md")) {
  .card {
    @include make-card--reverse;
  }
}
<div class="card">...

Reviewers: You can verify the new card behavior on the Enterprise page:
https://deploy-preview-1872--linkerdio.netlify.app/enterprise/

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I guess? 🙂

@travisbeckham travisbeckham merged commit 6ad88ff into main Nov 5, 2024
7 checks passed
@travisbeckham travisbeckham deleted the travis/card branch November 5, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants