Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Angular-ui from mean stack. #248

Closed
ronnross opened this issue Jan 25, 2014 · 5 comments
Closed

Removing Angular-ui from mean stack. #248

ronnross opened this issue Jan 25, 2014 · 5 comments

Comments

@ronnross
Copy link

I propose removing Angular-ui from the mean stack. My reasoning: angular-ui breaks out of the box features that come with bootstrap.js. For example, the responsive nav while in a collapsed state fails to display the menu drop-down when the menu button is clicked (angular-ui/bootstrap#1672). Who's know what other oob features are not working. I've only been using mean for a few days and really like the framework, but without bootstrap's responsive features it falls short for my needs. I would be happy to remove this and replace it with the bootstrap.js. I just wanted to hear the response from the Mean community.

@hartmamt
Copy link

I agree. I read your discussion with in the angular-ui issue and I think your proposal here makes sense.

@Foxandxss
Copy link

I still think that he is barking at the wrong tree.

@ronnross
Copy link
Author

@Foxandxss wouldn't this be a matter of opinion? It's seems that you are ok with with loosing out of the box features of bootstrap in lieu of extra features that angular-ui provides, and this is fine. I just wanted to ask the Mean community if they share that opinion. For example loosing all the responsive features of the navbar, and having to recreate that boilerplate doesn't (Imho) seem worth having some extra features. So, I wanted to offer up removing angular-ui from the framework in favor of having jquery and bootstrap.js native. That way when someone pulls down the Mean framework the navbar is responsive out of the gate.

@VikramTiwari
Copy link
Member

@ronnross You can use angular-ui elements at specific places rather than using it on the whole app. I do that all the time. Use vanilla bootstrap when you wish, and use angular-ui for some of their specific features.

And i agree with @Foxandxss. You can contribute to angular-ui or have your own in-house js for responsiveness.

PS: Not a big fan of angular-ui, but it works.

@liorkesos
Copy link
Member

@ellman is working on the modules branch which will let us extend and modularize what we offer.
Then I think it make sense to make mean as lean as possible.
Till then I think that applying the pareto law 80% of angular newbies will enjoy the additional abstraction that angular-ui delivers.
Regarding your specific issue you can simply exclude angular-ui from footer.jade for now.

sarareisner pushed a commit to liorkesos/mean that referenced this issue Mar 27, 2017
…n-libs

feat(sourcemap): Proper source maps for 3rd party packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants