Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated gh-actions, added no-apl #1772

Merged
merged 33 commits into from
Oct 28, 2024
Merged

fix: updated gh-actions, added no-apl #1772

merged 33 commits into from
Oct 28, 2024

Conversation

Ani1357
Copy link
Contributor

@Ani1357 Ani1357 commented Oct 23, 2024 •
edited
Loading

This PR:

  • adds support for deploying an lke cluster without APL
  • uses wildcard domains
  • fixes domain name generation
  • add support for deploying with a random(valid) domain if/when needed

@Ani1357 Ani1357 marked this pull request as draft October 24, 2024 07:31
@Ani1357 Ani1357 marked this pull request as ready for review October 24, 2024 11:14
ferruhcihan
ferruhcihan reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just wondering—would it be better to move the No-apl option under the installation profile instead of domain zone?

@Ani1357
Copy link
Contributor Author

Ani1357 commented Oct 25, 2024

LGTM! Just wondering—would it be better to move the No-apl option under the installation profile instead of domain zone?

I agree. Update code accordingly.

CasLubbers
CasLubbers approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one remark about inconsistency of No-Apl -> no-apl

.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
@Ani1357 Ani1357 enabled auto-merge (squash) October 28, 2024 13:29
@Ani1357 Ani1357 merged commit af37325 into main Oct 28, 2024
5 checks passed
@Ani1357 Ani1357 deleted the gh-actions-fix branch October 28, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferruhcihan ferruhcihan ferruhcihan approved these changes

@CasLubbers CasLubbers CasLubbers approved these changes

@j-zimnowoda j-zimnowoda Awaiting requested review from j-zimnowoda

@ElderMatt ElderMatt Awaiting requested review from ElderMatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ani1357 @CasLubbers @ferruhcihan @j-zimnowoda