Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add init container for oauth2 proxy #1779

Merged
merged 8 commits into from
Oct 28, 2024
Merged

fix: add init container for oauth2 proxy #1779

merged 8 commits into from
Oct 28, 2024

Conversation

srodenhuis
Copy link
Contributor

Add an additional init container to oauth2 proxy to check availability of OIDC issuer URL before starting oauth2 proxy

Ani1357
Ani1357 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as expected.

CasLubbers
CasLubbers approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected ✅

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) October 28, 2024 15:35
@j-zimnowoda j-zimnowoda merged commit e3886cc into main Oct 28, 2024
5 checks passed
@j-zimnowoda j-zimnowoda deleted the sr-oauth2-init branch October 28, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasLubbers CasLubbers CasLubbers approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

@j-zimnowoda j-zimnowoda Awaiting requested review from j-zimnowoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srodenhuis @CasLubbers @Ani1357 @j-zimnowoda