Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: harbor app operator #104

Merged
merged 25 commits into from
Jul 9, 2024
Merged

feat: harbor app operator #104

merged 25 commits into from
Jul 9, 2024

Conversation

ferruhcihan
Copy link
Contributor

Implements:

https://jira.linode.com/browse/APL-25

Description:

This PR eliminates the harbor-tasks files, integrating its tasks into the harbor-app-operator for improved task management.
Is paired with: linode/apl-core#1628

Copy link

gitguardian bot commented Jul 2, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
6228247 Triggered Generic Password 03c4171 src/operator/harbor.ts View secret
6228247 Triggered Generic Password 86fb189 src/operator/harbor.ts View secret
6228247 Triggered Generic Password 08707ed src/operator/harbor.ts View secret
6228247 Triggered Generic Password 24c793d src/operator/harbor.ts View secret
6228247 Triggered Generic Password 4e49e11 src/operator/harbor.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, functionality is still working and old stuff is removed

@ferruhcihan ferruhcihan merged commit 0502050 into main Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants