Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gzipped metadata #65

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

eljohnson92
Copy link
Contributor

📝 Description

What does this PR do and why is this change necessary?
This PR adds support for gzipped metadata by transparently checking if the base64 decoded bytes are gzipped.

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?
unit tests have been updated to mock various responses from the metadata-api including valid and invalid gzipped data.
How do I run the relevant unit/integration tests?
make test should validate this code change works

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@eljohnson92 eljohnson92 requested a review from a team as a code owner September 9, 2024 17:48
@eljohnson92 eljohnson92 requested review from zliang-akamai and ezilber-akamai and removed request for a team September 9, 2024 17:48
Copy link

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Tests are passing locally.

userdata.go Outdated Show resolved Hide resolved
@zliang-akamai zliang-akamai merged commit b84b6b4 into linode:main Sep 16, 2024
1 check passed
@zliang-akamai zliang-akamai added the new-feature for new features in the changelog. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants