bug: Fix SignatureDoesNotMatch when putting files with special characters #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters Related to #277 @mechpaul discovered that putting filenames with some special characters, such as `\` and `$` using the `obj` plugin returns a SignatureDoesNotMatch error. To reproduce: ```bash $ echo "test" > 'test$file\name' $ python3 -m linodecli obj put 'test$file\name' some-bucket ``` This change properly quotes the URLs such that these characters are accepted in keys.
|
This fix works for uploading, but it causes problems in the web GUI.
I was not able to test how it worked for public read. Setting the ACL to Public Read threw another exception: Unable to set object's ACL: SignatureDoesNotMatch. Should keys in the object bucket be unescaped? |
|
Hmm.. it does appear that the key is being stored escaped. That's not what I intended - I'll revisit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #277
@mechpaul discovered that putting filenames with some special
characters, such as
\and$using theobjplugin returns aSignatureDoesNotMatch error.
To reproduce:
This change properly quotes the URLs such that these characters are
accepted in keys.