Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filter string generation #145

Merged
merged 10 commits into from
Sep 16, 2021
Merged

Add Filter string generation #145

merged 10 commits into from
Sep 16, 2021

Conversation

zdypro888
Copy link
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@phillc
Copy link
Contributor

phillc commented May 6, 2020

Hello,
This is an interesting idea. We are circulating this internally for feedback. Thank you for the PR!

LBGarber pushed a commit to LBGarber/linodego that referenced this pull request Mar 15, 2021
@0xch4z
Merge pull request linode#145 from Charliekenney23/chore/vendor-deps
0ef1a4c 
vendor dependencies
LBGarber
LBGarber suggested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@LBGarber LBGarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea! Here are a few ways we can simplify the logic.

comparison.go Outdated Show resolved Hide resolved
comparison.go Show resolved Hide resolved
jriddle-linode and others added 2 commits September 16, 2021 14:10
@jriddle-linode @LBGarber
add getJSONValueString
519b41d 
Co-authored-by: Lena Garber <[email protected]>
@jriddle-linode @LBGarber
add getJSONValueString
b1597c1 
Co-authored-by: Lena Garber <[email protected]>
LBGarber
LBGarber approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@LBGarber LBGarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@LBGarber LBGarber changed the title add comparison Add Filter string generation Sep 16, 2021
@jriddle-linode jriddle-linode merged commit dd5fe73 into linode:main Sep 16, 2021
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
@zdypro888 @LBGarber
Add Filter string generation (linode#145)
3b83860 
add helper functions to generate filter strings based on
https://www.linode.com/docs/api/#filtering-and-sorting
todo: add order-by

Co-authored-by: zdypro <[email protected]>
Co-authored-by: Jacob Riddle <[email protected]>
Co-authored-by: Lena Garber <[email protected]>
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
@zdypro888 @LBGarber
Add Filter string generation (linode#145)
6c068bc 
add helper functions to generate filter strings based on
https://www.linode.com/docs/api/#filtering-and-sorting
todo: add order-by

Co-authored-by: zdypro <[email protected]>
Co-authored-by: Jacob Riddle <[email protected]>
Co-authored-by: Lena Garber <[email protected]>
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
@zdypro888 @LBGarber
Add Filter string generation (linode#145)
d390dfa 
add helper functions to generate filter strings based on
https://www.linode.com/docs/api/#filtering-and-sorting
todo: add order-by

Co-authored-by: zdypro <[email protected]>
Co-authored-by: Jacob Riddle <[email protected]>
Co-authored-by: Lena Garber <[email protected]>
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 14, 2023
@zdypro888 @LBGarber
Add Filter string generation (linode#145)
0bb4211 
add helper functions to generate filter strings based on
https://www.linode.com/docs/api/#filtering-and-sorting
todo: add order-by

Co-authored-by: zdypro <[email protected]>
Co-authored-by: Jacob Riddle <[email protected]>
Co-authored-by: Lena Garber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LBGarber LBGarber LBGarber approved these changes

@0xch4z 0xch4z Awaiting requested review from 0xch4z

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zdypro888 @phillc @LBGarber @jriddle-linode