Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting API protocol in SetBaseURL #227

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

LBGarber
Copy link
Contributor

Resolves #226

@LBGarber LBGarber changed the title Allow setting the API protocol in SetBaseURL Allow setting API protocol in SetBaseURL Nov 16, 2021
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LBGarber LBGarber merged commit e99d63e into linode:main Nov 16, 2021
tjhop added a commit to tjhop/prometheus that referenced this pull request Nov 16, 2021
This fixes failing builds when upgrading the linodego library:
prometheus#9763

*Note*: this requires `v1.2.1` of the linodego library to work

See also:
linode/linodego#226
linode/linodego#227
https://github.com/linode/linodego/releases/tag/v1.2.1

Signed-off-by: TJ Hoplock <[email protected]>
tjhop added a commit to tjhop/prometheus that referenced this pull request Nov 16, 2021
This fixes failing builds due to the version bump of linodego to
`v1.2.1`.

Fixes:
prometheus#9763

See also:
linode/linodego#226
linode/linodego#227
https://github.com/linode/linodego/releases/tag/v1.2.1

Signed-off-by: TJ Hoplock <[email protected]>
tjhop added a commit to tjhop/prometheus that referenced this pull request Nov 16, 2021
This fixes failing builds due to the version bump of linodego to
`v1.2.1`.

Fixes:
prometheus#9763

See also:
linode/linodego#226
linode/linodego#227
https://github.com/linode/linodego/releases/tag/v1.2.1

Signed-off-by: TJ Hoplock <[email protected]>
roidelapluie pushed a commit to prometheus/prometheus that referenced this pull request Nov 16, 2021
* build(deps): bump github.com/linode/linodego from 1.1.0 to 1.2.1
* fix: linode SD tests

This fixes failing builds due to the version bump of linodego to
`v1.2.1`.

Fixes:
#9763

See also:
linode/linodego#226
linode/linodego#227
https://github.com/linode/linodego/releases/tag/v1.2.1

Signed-off-by: TJ Hoplock <[email protected]>
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: updateHostURL() forces HTTPS for connections, affecting SetBaseURL(), SetAPIVersion(), etc
2 participants