-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting API protocol in SetBaseURL #227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBGarber
changed the title
Allow setting the API protocol in SetBaseURL
Allow setting API protocol in SetBaseURL
Nov 16, 2021
jriddle-linode
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tjhop
added a commit
to tjhop/prometheus
that referenced
this pull request
Nov 16, 2021
This fixes failing builds when upgrading the linodego library: prometheus#9763 *Note*: this requires `v1.2.1` of the linodego library to work See also: linode/linodego#226 linode/linodego#227 https://github.com/linode/linodego/releases/tag/v1.2.1 Signed-off-by: TJ Hoplock <[email protected]>
tjhop
added a commit
to tjhop/prometheus
that referenced
this pull request
Nov 16, 2021
This fixes failing builds due to the version bump of linodego to `v1.2.1`. Fixes: prometheus#9763 See also: linode/linodego#226 linode/linodego#227 https://github.com/linode/linodego/releases/tag/v1.2.1 Signed-off-by: TJ Hoplock <[email protected]>
tjhop
added a commit
to tjhop/prometheus
that referenced
this pull request
Nov 16, 2021
This fixes failing builds due to the version bump of linodego to `v1.2.1`. Fixes: prometheus#9763 See also: linode/linodego#226 linode/linodego#227 https://github.com/linode/linodego/releases/tag/v1.2.1 Signed-off-by: TJ Hoplock <[email protected]>
roidelapluie
pushed a commit
to prometheus/prometheus
that referenced
this pull request
Nov 16, 2021
* build(deps): bump github.com/linode/linodego from 1.1.0 to 1.2.1 * fix: linode SD tests This fixes failing builds due to the version bump of linodego to `v1.2.1`. Fixes: #9763 See also: linode/linodego#226 linode/linodego#227 https://github.com/linode/linodego/releases/tag/v1.2.1 Signed-off-by: TJ Hoplock <[email protected]>
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #226