Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add documentation snippets for Placement Groups LA #530

Merged

Conversation

lgarber-akamai
Copy link
Contributor

📝 Description

This pull request adds a note to various inline documentation comments informing users that PGs may not currently be available for all users.

✔️ How to Test

N/A

@lgarber-akamai lgarber-akamai added the documentation for updates to the documentation in the changelog. label Jun 18, 2024
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner June 18, 2024 15:11
@lgarber-akamai lgarber-akamai requested review from ykim-1 and yec-akamai and removed request for a team June 18, 2024 15:11
@lgarber-akamai lgarber-akamai changed the title Add documentation snippets for PG LA doc: Add documentation snippets for PG LA Jun 18, 2024
@lgarber-akamai lgarber-akamai changed the title doc: Add documentation snippets for PG LA doc: Add documentation snippets for Placement Groups LA Jun 18, 2024
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice to have these notes!

Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgarber-akamai lgarber-akamai merged commit 9bb3d96 into linode:proj/vm-placement Jun 20, 2024
4 checks passed
renovate bot added a commit to anza-labs/lke-operator that referenced this pull request Jun 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/linode/linodego](https://togithub.com/linode/linodego) |
`v1.35.0` -> `v1.36.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2flinode%2flinodego/v1.36.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2flinode%2flinodego/v1.36.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2flinode%2flinodego/v1.35.0/v1.36.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2flinode%2flinodego/v1.35.0/v1.36.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>linode/linodego (github.com/linode/linodego)</summary>

###
[`v1.36.0`](https://togithub.com/linode/linodego/releases/tag/v1.36.0)

[Compare
Source](https://togithub.com/linode/linodego/compare/v1.35.0...v1.36.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### ⚠️  Breaking Change

- Renamed capability consts by
[@&#8203;ErikZilber](https://togithub.com/ErikZilber) in
[linode/linodego#529

##### 🚀 New Features

- Project VM Placement by
[@&#8203;lgarber-akamai](https://togithub.com/lgarber-akamai) in
[linode/linodego#521
- Add event entities enums and actions VM Placement by
[@&#8203;lgarber-akamai](https://togithub.com/lgarber-akamai) in
[linode/linodego#492
- Expose `OnAfterResponse` middleware hook by
[@&#8203;tchinmai7](https://togithub.com/tchinmai7) in
[linode/linodego#512
- Add new tax_id_invalid event by
[@&#8203;jcallahan-akamai](https://togithub.com/jcallahan-akamai) in
[linode/linodego#514

##### 💡 Improvements

- Fix case in name for `Client.UnassignPlacementGroupLinodes(...)` by
[@&#8203;lgarber-akamai](https://togithub.com/lgarber-akamai) in
[linode/linodego#496

##### 🧪 Testing Improvements

- Add Cloud Firewall for integration tests by
[@&#8203;ykim-1](https://togithub.com/ykim-1) in
[linode/linodego#515
- Add Calico Inbound and Outbound policies to LKE nodes for E2E by
[@&#8203;ykim-1](https://togithub.com/ykim-1) in
[linode/linodego#525

##### 📖 Documentation

- Add warning for LKE control plane ACL by
[@&#8203;lgarber-akamai](https://togithub.com/lgarber-akamai) in
[linode/linodego#523
- Add documentation snippets for Placement Groups LA by
[@&#8203;lgarber-akamai](https://togithub.com/lgarber-akamai) in
[linode/linodego#530

##### 📦 Dependency Updates

- build(deps): bump golang.org/x/text from 0.15.0 to 0.16.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[linode/linodego#518
- build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[linode/linodego#519
- build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[linode/linodego#520

#### New Contributors

- [@&#8203;tchinmai7](https://togithub.com/tchinmai7) made their first
contribution in
[linode/linodego#512
- [@&#8203;ErikZilber](https://togithub.com/ErikZilber) made their first
contribution in
[linode/linodego#529

**Full Changelog**:
linode/linodego@v1.35.0...v1.36.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/anza-labs/lke-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2RlcGVuZGVuY3kiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation for updates to the documentation in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants