Restored legacy PagedResponse structs and added deprecation notice #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
jriddle-linode and
ykim-akamai
and removed request for
a team
|
Just a thought, since they are all in the root package |
Good idea! It would make it much simpler to phase them out when that eventually happens. |
ezilber-akamai
force-pushed
the
TPT-3026-restore_paged_response_structs
branch
from
c8fa872
to
6d16efe
Compare
zliang-akamai
approved these changes
Jul 3, 2024
| @@ -0,0 +1,55 @@ | |||
| package linodego | |||
|
|
|||
| // Deprecated: AccountAvailabilityPagedResponse exists for historical compatibility and should not be used. | |||
There was a problem hiding this comment.
optional: We can do something like this to make this a bit tidier:
type (
// Deprecated: AccountAvailabilityPagedResponse exists for historical compatibility and should not be used.
AccountAvailabilityPagedResponse legacyPagedResponse[AccountAvailability]
// Deprecated: AccountBetasPagedResponse exists for historical compatibility and should not be used.
AccountBetasPagedResponse legacyPagedResponse[AccountBetaProgram]
// ...
)
lgarber-akamai
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Restored legacy PagedResponse structs and added deprecation notice