fix: Separate plan availability logic from getRegionsWithCaps(...) #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
requested review from
ykim-akamai and
yec-akamai
and removed request for
a team
jriddle-linode
approved these changes
Jul 23, 2024
ezilber-akamai
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request separates the plan availability logic from getRegionWithCaps(...) into a separate getRegionsWithCapsAndPlans(...) function.
This prevents us from needing to specify desired plans for tests that don't need them, and lets us avoid re-running all test fixtures as a bonus.
This should resolve the following errors in CI:
✔️ How to Test
make SKIP_LINT=1 test