Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Images Service Gen2 #560

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Project: Images Service Gen2 #560

merged 11 commits into from
Aug 9, 2024

Conversation

yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented Jul 25, 2024

📝 Description

Project image gen2 LA

✔️ How to Test

make testint
make testunit

lgarber-akamai and others added 2 commits June 28, 2024 12:06
* WIP
oops

* Add unit test case

* Drop go.work.sum from source tree

* oops

* Add tags to ImageUploadOptions

* Separate ImageStatus from ImageRegionStatus

* Fix tests; add WaitForImageRegionStatus
@yec-akamai yec-akamai added the project for new projects in the changelog. label Jul 25, 2024
@yec-akamai yec-akamai marked this pull request as ready for review August 8, 2024 18:49
@yec-akamai yec-akamai requested a review from a team as a code owner August 8, 2024 18:49
@yec-akamai yec-akamai requested review from lgarber-akamai and ezilber-akamai and removed request for a team August 8, 2024 18:49
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great after the fixture mismatch is fixed!

@ykim-akamai ykim-akamai self-requested a review August 9, 2024 15:30
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@yec-akamai yec-akamai merged commit 7f1781b into main Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project for new projects in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants