Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Golang to v1.22 #569

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Bump Golang to v1.22 #569

merged 3 commits into from
Aug 21, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Aug 19, 2024

📝 Description

Go v1.21 has been EOL

Why it's a breaking change? It makes some changes that's not compatible with Go v1.21, but this is definitely debatable.

You can see the errors in the CI run of the first commit to see those incompatible changes suggested by the linter for Go v1.22.

@zliang-akamai zliang-akamai requested a review from a team as a code owner August 19, 2024 18:19
@zliang-akamai zliang-akamai requested review from lgarber-akamai and ykim-akamai and removed request for a team August 19, 2024 18:19
@zliang-akamai zliang-akamai added the breaking-change for breaking changes in the changelog. label Aug 19, 2024
@zliang-akamai zliang-akamai changed the title Bump Golang to 1.22 Bump Golang to v1.22 Aug 20, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for handling this!

@zliang-akamai zliang-akamai merged commit 23902e3 into main Aug 21, 2024
6 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/go-1.22 branch August 21, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change for breaking changes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants