-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7977] - Surface interface error in Linode Config dialog #10429
Merged
mjac0bs
merged 4 commits into
linode:develop
from
mjac0bs:M3-7977-improve-edit-config-error-visibility
May 29, 2024
Merged
fix: [M3-7977] - Surface interface error in Linode Config dialog #10429
mjac0bs
merged 4 commits into
linode:develop
from
mjac0bs:M3-7977-improve-edit-config-error-visibility
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
mjac0bs
force-pushed
the
M3-7977-improve-edit-config-error-visibility
branch
from
May 24, 2024 20:26
aa1c0d7
to
f4db602
Compare
mjac0bs
changed the title
fix: [M3-7977] - Improve visibility of errors in Linode Config dialog
fix: [M3-7977] - Surface interface error in Linode Config dialog
May 28, 2024
mjac0bs
requested review from
jdamore-linode and
abailly-akamai
and removed request for
a team
May 28, 2024 21:00
Coverage Report: ✅ |
abailly-akamai
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming error is now visible and scrolled into view ✅
mjac0bs
added
Add'tl Approval Needed
Waiting on another approval!
and removed
Ready for Review
labels
May 29, 2024
bnussman-akamai
approved these changes
May 29, 2024
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
There were a couple of problems in the Add/Edit Configuration dialog:
This was fixed in PR feat: [M3-8069] - scrollErrorIntoViewV2 - POC #10459: General errors were not reliably being focused byscrollErrorIntoView
because the scrolling can happen before the general error is updated in form state (viaformik.setStatus
), and therefore there is no notice to scroll to in the DOM, sincegeneralError
being defined is a condition for rendering the notice.Note
This PR's scope is small. There is more going on with the Linode Config Dialog because it's too large of a component handling both Create and Edit state and should be refactored. This is resulting in:
interfaces
array causing it to sometimes display incorrect form values for interfaces in Create (or Edit) mode, depending on the actions the user has taken, e.g. previously opening the Edit (or Create).primary
(interface) is set tofalse
. Instead of seeing the same error as in the Add Config dialog detailed beflow, the request submits successfully but the interfaces no longer have a primary interface.Creating a follow up ticket with subtasks to refactor this component and address its issues: M3-8165.
Changes 🔄
Target release date 🗓️
6/10
Preview 📷
How to test 🧪
Reproduction steps
(How to reproduce the issue, if applicable)
Error: assigning a VLAN to eth0 is not a valid configuration, but does not surface an error
Repro:
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply