Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8128] - Query Key Factory for Support Tickets #10496

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented May 21, 2024

Description 📝

Updates Support Ticket Queries to use a query key factory and latest patterns

Changes 🔄

  • Uses query key factory for support ticket queries 🏭
  • Uses v5 compatible patterns to make upgrading easier in the future 📦 (see here)
  • Updates mutation handles to be a bit more optimized with the invalidations 🔁

Preview 📷

Note

No UI changes

Screenshot 2024-05-21 at 2 07 24 PM

How to test 🧪

Warning

I recommend testing this in dev so that our support team does not get test tickets coming in

  • Test support tickets in general
  • Test creating a Support Ticket
    • Verify cache updates as expected
  • Test adding a comment to a support ticket
    • Verify cache updates as expected

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the React Query Relating to the transition to use React Query label May 21, 2024
@bnussman-akamai bnussman-akamai self-assigned this May 21, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 21, 2024 18:24
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and hkhalil-akamai and removed request for a team May 21, 2024 18:24
Copy link

github-actions bot commented May 21, 2024

Coverage Report:
Base Coverage: 81.62%
Current Coverage: 81.62%

@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 22, 2024 00:41
@bnussman-akamai bnussman-akamai requested review from cliu-akamai and removed request for a team May 22, 2024 00:41
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looking good! Verified:

  • Viewing existing tickets
  • Opening new tickets
  • Creating replies
  • Adding attachments

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels May 23, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the RQ query keys make sense and the RQ cache updated as I created new tickets (with and without entities), updated the tickets with comments, and closed the tickets. Also confirmed events were updating as expected for support ticket creation and updating. Tests look good.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 28, 2024
@bnussman-akamai bnussman-akamai merged commit c849cfe into linode:develop May 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! React Query Relating to the transition to use React Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants