feat: [M3-7883] - Add search and alphabetical sorting to Switch Account drawer #10515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
requested review from
AzureLatte,
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
… to Switch Account drawer
mjac0bs
commented
May 24, 2024
Comment on lines
-122
to
-126
| {(isSwitchingChildAccounts || isLoading) && ( | ||
| <Box display="flex" justifyContent="center" width={'100%'}> | ||
| <CircleProgress mini size={70} /> | ||
| </Box> | ||
| )} |
There was a problem hiding this comment.
I'm not sure why we were setting up loading spinners in two different places, but I removed this and added all conditions to L67-72. The addition of isRefetching handles loading state for the search queries. Reviewers should check that they're not seeing any unexpected behavior in our handling of loading state.
| @@ -67,7 +79,10 @@ export const ChildAccountList = React.memo( | |||
|
|
|||
| if (childAccounts?.length === 0) { | |||
| return ( | |||
| <Notice variant="info">There are no indirect customer accounts.</Notice> | |||
| <Notice variant="info"> | |||
| There are no child accounts | |||
There was a problem hiding this comment.
We're not using "indirect customer", so updated the terminology here.
packages/manager/src/features/Account/SwitchAccounts/ChildAccountList.tsx
Outdated
Show resolved
Hide resolved
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
May 24, 2024
There was a problem hiding this comment.
Thanks for adding this test
packages/manager/src/features/Account/SwitchAccounts/ChildAccountList.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Account/SwitchAccounts/ChildAccountList.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
approved these changes
May 28, 2024
mjac0bs
added
Approved
jdamore-linode
approved these changes
May 28, 2024
dwiley-akamai
approved these changes
May 28, 2024
jaalah-akamai
approved these changes
May 30, 2024
There was a problem hiding this comment.
Nice work @mjac0bs 🚀
Screen.Recording.2024-05-29.at.10.42.05.PM.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR brings two improvements to the Switch Account drawer, allowing users with hundreds of child accounts to more easily navigate that list:
We are already incrementally fetching the list using an infinite query, but the existing UI still requires scrolling and visually searching, which can be a burden on the user.
Changes 🔄
Target release date 🗓️
06/10
Preview 📷
Screen.Recording.2024-05-24.at.9.44.03.AM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
/child-accountsrequest.As an Author I have considered 🤔
Check all that apply