-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8183] - Clean up loading components #10524
refactor: [M3-8183] - Clean up loading components #10524
Conversation
@@ -88,9 +87,6 @@ export const WrapperMenuItem = (props: WrapperMenuItemCombinedProps) => { | |||
{...rest} | |||
className={`${classes.root} ${className} ${tooltip && 'hasTooltip'}`} | |||
> | |||
{isLoading && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This loading state was never used
packages/manager/src/features/Linodes/LinodeCreatev2/Tabs/Backups/BackupSelect.tsx
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/OveragePricing.tsx
Show resolved
Hide resolved
Coverage Report: ❌ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! PR looks good. left some comments & suggestions
packages/manager/src/features/Linodes/LinodeCreatev2/Tabs/Backups/BackupSelect.tsx
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/OveragePricing.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Cleanup! did not notice regressions through the flows. Thanks for looking at improving the size API ✨
One improvement remains IMO:
when we don't enforce a size, <CircleProgress />
has different treatment:
It's larger and features an inner circle. it's a common loader since it is used for the splashscreen and and loading landing page
For the sake of addressing this globally and make the component's API clear (right now it's unclear NOT adding a prop renders the largest version), i think we should either:
- require size, add a
lg
option and add it to all circle progress without a size prop (will increase PR size but it's a no regression change) - still add an
lg
option, and set it by default in the component. - for either option, i would suggest removing the inner circle cause i am not sure what it adds?
These are just suggestions, it's not a deal breaker to go along with this cleanup. Approving pending whatever solution you go with and others chiming in
packages/manager/src/features/Linodes/LinodeCreatev2/Tabs/Marketplace/AppsList.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could consider disableShrink
. I think it looks slightly better, but I'm not sure
packages/manager/src/components/CircleProgress/CircleProgress.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Nice clean up! 🧹
Description 📝
We have a lot of loading components that are all basically just variations of CircleProgress. This PR cleans up those components.
I also moved the overage pricing tooltip text position in the Object Storage Create Bucket drawer to the top so that the tooltip doesn't block the CTA buttons
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply