-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7784] - Cypress integration tests for Placement Group update label flow #10529
Conversation
packages/manager/cypress/e2e/core/placementGroups/update-placement-group-label.spec.ts
Show resolved
Hide resolved
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @carrillo-erik! Posted a couple suggestions involving the mocks and your comment, but the tests themselves are looking really good! Ping me once you make any changes and I'd be happy to re-review!
packages/manager/cypress/support/intercepts/placement-groups.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/placementGroups/update-placement-group-label.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/placementGroups/update-placement-group-label.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the updates @carrillo-erik! Looks (and runs) great!
Thanks for handling this one! Test coverage is good ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Erik, test looks good and you've got the approvals - I just noticed a few small bits of clean up that could be addressed.
Description 📝
This adds Cypress integration tests for the Placement Group update label flow via Placement Group's landing page.
Changes 🔄
List any change relevant to the reviewer.
mockUpdatePlacementGroupLabel()
andmockUpdatePlacementGroupLabelError()
Target release date 🗓️
06/10/2024
How to test 🧪
Prerequisites
debug
mode by runningyarn cy:debug
.Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply