change: [M3-8159] - Modify limited availability banner display logic #10536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
AzureLatte,
jdamore-linode and
mjac0bs
and removed request for
a team
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
- Confirmed the "learn more" link has moved from the notice to the class description helper text above the plans table
- Confirmed that the notice displays if the majority of plans are disabled and tooltip does not; else, the inverse
- Test passing 🧪
Approving, but noting one thing.
For this branch, compared to dev (which is the only place I can see Bare Metal), we're now seeing two notices and the class description copy is not visible. I don't have much familiarity with the Bare Metal plans, so not sure if this change was intended, impactful, or not.
| Dev | This Branch |
|---|---|
packages/manager/src/features/components/PlansPanel/PlansPanel.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Mariah Jacobs <[email protected]>
|
thanks @mjac0bs - bare metal plans are kind of a special case (and you need an account flag for them to even show up). This is prolly a bit out of scope but i removed the display of the limited availability banner for them anyway since they handle their own. Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR modifies the display logic of the limited availability banner in the Selection Plan. This is the result of product wanted to limit the display of the banner, especially as it relates to the 512Gb plan since the banner would always display for any class with a 512 plan.
The solution was to only display the banner if more than half of the plans are disabled. Since that logic already existed for the disabled tooltip, I leveraged this util to apply it to the notice.
As a result, the logic is as follow:
Additionally, it was decided to include the "learn more" link in the Class description copy and remove it from the banner so it is always available for the user now that the banner won't display often.
Changes 🔄
Target release date 🗓️
6/10/2024
Preview 📷
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply