change: [M3-8153] - Rename to Choose an OS in Linode Create flow #10554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-linode
force-pushed
the
M3-8153-rename-distribution-to-os
branch
from
3af4950
to
9ef3408
Compare
hana-linode
requested review from
jdamore-linode,
mjac0bs and
cpathipa
and removed request for
a team
mjac0bs
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Confirmed the copy change and test coverage, left a couple questions out of curiosity. 🚢
I happened to see flake running stackscripts/smoke-community-stackscripts.spec.ts locally, but seems like it's an unrelated issue with the paginated/infinite scrolling test.
| @@ -19,7 +19,7 @@ export const Distributions = () => { | |||
|
|
|||
| return ( | |||
| <Paper> | |||
| <Typography variant="h2">Choose a Distribution</Typography> | |||
| <Typography variant="h2">Choose an OS</Typography> | |||
There was a problem hiding this comment.
A couple of questions:
- Was this change motivated by the name change to "distributed" for Gecko or something else?
- Did we opt for "OS" rather than "Operating System" because it's more concise and the term is widely understood? (We were spelling out Distribution rather than abbreviating it "Distro", for example, so just curious.)
There was a problem hiding this comment.
- Yes, this change was motivated by the name change to distributed for Gecko
- Not exactly sure what UX's reasoning was for OS vs Operating System but I assume it was bc it's more concise and is a term that's widely understood
cpathipa
approved these changes
Jun 11, 2024
mjac0bs
added
Approved
Co-authored-by: Mariah Jacobs <[email protected]>
|
Coverage Report: ✅ |
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Rename
Choose a DistributiontoChoose an OSin the Linode Create flow. The tab will stay as Distribution for now.Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
/linodes/create?type=DistributionsAs an Author I have considered 🤔
Check all that apply