Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8218] - Obj fix for crashing accesskey page when relevant customer tags are not added. #10555

Merged

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Jun 7, 2024

Description πŸ“

This PR prevents causing potential defect of crashing the Access key landing page when flag is on but no tags are assigned to the customer.

Target release date πŸ—“οΈ

6/10

How to test πŸ§ͺ

Reproduction steps

(How to reproduce the issue, if applicable)

  • Checkout to develop
  • Turn the OBJ flan on. use the account that doesn't have obj regions tag.
  • Verify the Accesskey landing page.

Verification steps

(How to verify changes)

  • Checkout to develop
  • Turn the OBJ flan on. use the account that doesn't have obj regions tag.
  • Verify Accesskey landing page.
  • Verify Edit/ Permission / Revoke actions for the key.

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner June 7, 2024 16:35
@cpathipa cpathipa requested review from bnussman-akamai and hana-linode and removed request for a team June 7, 2024 16:35
@cpathipa cpathipa marked this pull request as draft June 7, 2024 16:35
@cpathipa cpathipa self-assigned this Jun 7, 2024
@cpathipa cpathipa changed the title Obj fix crashing accesskey page upcoming: [M3-8218] - Obj fix for crashing accesskey page when relevant customer tags are not added. Jun 7, 2024
@cpathipa cpathipa marked this pull request as ready for review June 7, 2024 16:59
Copy link

github-actions bot commented Jun 7, 2024

Coverage Report: βœ…
Base Coverage: 82.29%
Current Coverage: 82.29%

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Jun 7, 2024
Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that I didn't crash when visiting Obj pages

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jun 10, 2024
@cpathipa cpathipa changed the base branch from develop to release-v1.121.0 June 10, 2024 14:02
@cpathipa cpathipa merged commit 87e0fcb into linode:release-v1.121.0 Jun 10, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants