Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8216] - NodeBalancer Query Key Factory #10556

Conversation

bnussman-akamai
Copy link
Contributor

@bnussman-akamai bnussman-akamai commented Jun 7, 2024

Description 📝

  • Updates NodeBalancer queries to use a Query Key Factory and latest TanStack query patterns

Preview 📷

Note

No UI changes expected

How to test 🧪

  • Generally test all NodeBalancer related features
  • Test assigning / unassigning NodeBalancers from Firewalls
  • Verify all NodeBalancer automated tests pass

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added React Query Relating to the transition to use React Query NodeBalancers Relating to NodeBalancers labels Jun 7, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jun 7, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner June 7, 2024 17:55
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and cpathipa and removed request for a team June 7, 2024 17:55
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

  • Verified NodeBalancer functionality
  • Verified assigning / unassigning NodeBalancers from Firewalls

Copy link

github-actions bot commented Jun 10, 2024

Coverage Report:
Base Coverage: 82.76%
Current Coverage: 82.75%

@mjac0bs mjac0bs self-requested a review June 11, 2024 16:53
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Widespread NodeBalancer PRs always make me a little nervous because our e2e coverage is lacking for the feature. We really only test the basics of the create flow and empty state landing. It would be really nice to have test coverage for the landing page and details pages, but I think those exist somewhere in the backlog.

Spent some time testing functionality, including NBFW CRUD interactions, and things were looking good for the most part. See my comment about the issue with the getAllNodeBalancerConfigs query that was causing regressions.

packages/manager/src/queries/nodebalancers.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/nodebalancers.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/nodebalancers.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/nodebalancers.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/nodebalancers.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/nodebalancers.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/nodebalancers.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/nodebalancers.ts Show resolved Hide resolved
@bnussman-akamai
Copy link
Contributor Author

I think I got all of that addressed! Thanks for catching those ✏️ @mjac0bs

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnussman-akamai, all looks good now! 🚢

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Jun 12, 2024
@bnussman-akamai bnussman-akamai merged commit f3e361b into linode:develop Jun 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! NodeBalancers Relating to NodeBalancers React Query Relating to the transition to use React Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants