Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8232] - Query Key Factory for Firewalls #10568

Conversation

bnussman-akamai
Copy link
Contributor

@bnussman-akamai bnussman-akamai commented Jun 11, 2024

Description 📝

  • Migrates Firewalls to use a query key factory 🏭
  • Migrates to single object notation to prepare for TanStack Query v5 (see here) 🔧
  • Performs some clean up and optimizations where possible 🧹

Preview 📷

Note

No UI changes expected

How to test 🧪

  • Test general firewall actions
  • Test firewall actions on Linode Details page
    • We want to verify cache updates happen as expected
  • Test firewall actions on NodeBalancer settings page
    • We want to verify cache updates happen as expected
  • Verify all automated testing for Firewalls passes ✅

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the React Query Relating to the transition to use React Query label Jun 11, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jun 11, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review June 11, 2024 20:54
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner June 11, 2024 20:54
@bnussman-akamai bnussman-akamai requested review from mjac0bs and AzureLatte and removed request for a team June 11, 2024 20:54
Copy link

github-actions bot commented Jun 11, 2024

Coverage Report:
Base Coverage: 82.76%
Current Coverage: 82.76%

Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed.

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Work in Progress labels Jun 12, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up and cache updates look like they're happening as expected. Confirmed the general firewall create/delete, enable/disable, and add/remove rules. NodeBalancer and Linodes assigned updated accordingly. Also confirmed that unassigning a Firewall from a NB or Linode would update as expected on FW pages. Once tests pass, this should be good to go. 🚀

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jun 13, 2024
@bnussman-akamai bnussman-akamai merged commit 47dd6a7 into linode:develop Jun 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! React Query Relating to the transition to use React Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants